Skip to content

Update to latest plugin library #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: refactoring
Choose a base branch
from
Open

Update to latest plugin library #61

wants to merge 2 commits into from

Conversation

donny-dont
Copy link
Contributor

No description provided.

@donny-dont donny-dont requested a review from tboerger November 9, 2020 22:33
@donny-dont donny-dont force-pushed the refactoring-refactor branch 3 times, most recently from 45e2007 to be1b88b Compare November 9, 2020 22:58
@donny-dont donny-dont force-pushed the refactoring-refactor branch from d3ec438 to c61f344 Compare November 9, 2020 23:11
tboerger
tboerger approved these changes Nov 22, 2020
View reviewed changes
Copy link
Contributor

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, beside LGTM

plugin/impl.go

defer resp.Body.Close()

if /*p.settings.Debug ||*/ resp.StatusCode >= http.StatusBadRequest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented the debugging part?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tboerger tboerger tboerger approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donny-dont @tboerger